skills/
  code-review/
    SKILL.md
    checklist.md
    examples/
      review-output.md

---
name: code-review
description: Use when the user asks to review code, find bugs, audit changes, or check a pull request.
---

# Code Review Skill

You are reviewing code for correctness, security, performance, maintainability, and tests.

## Workflow

1. Understand the change context.
2. Inspect the diff and related files.
3. Check correctness and edge cases.
4. Check security and data exposure risks.
5. Check performance risks.
6. Check whether tests cover the changed behavior.
7. Report findings first, ordered by severity.

## Review Checklist

- Security: injection, auth, authorization, secrets, unsafe commands.
- Correctness: null handling, race conditions, resource leaks, error paths.
- Performance: repeated expensive work, blocking operations, large allocations.
- Maintainability: naming, duplication, complexity, dead code.
- Testing: missing critical paths, weak assertions, untested edge cases.

## Output Format

### Findings

1. [severity] file:line - issue description
   Impact: what can go wrong.
   Fix: suggested change.

### Open Questions

- ...

### Summary

Short overall assessment.

---
name: code-review
description: Use when the user asks to review code, find bugs, audit changes, or check a pull request.
---

from dataclasses import dataclass
from pathlib import Path
from typing import Callable


SKILLS_DIR = WORKDIR / "skills"


@dataclass(frozen=True)
class SkillMeta:
    name: str
    description: str
    path: Path


def parse_skill_file(path: Path) -> tuple[SkillMeta, str]:
    text = path.read_text(encoding="utf-8")

    if not text.startswith("---"):
        raise ValueError(f"Skill file missing frontmatter: {path}")

    try:
        _, header, body = text.split("---", 2)
    except ValueError as exc:
        raise ValueError(f"Invalid skill frontmatter: {path}") from exc

    fields: dict[str, str] = {}
    for raw_line in header.strip().splitlines():
        if ":" not in raw_line:
            continue

        key, value = raw_line.split(":", 1)
        fields[key.strip()] = value.strip().strip("\"'")

    name = fields.get("name", "").strip()
    description = fields.get("description", "").strip()

    if not name:
        raise ValueError(f"Skill missing name: {path}")
    if not description:
        raise ValueError(f"Skill missing description: {path}")

    return SkillMeta(name=name, description=description, path=path), body.strip()

def discover_skills(skills_dir: Path = SKILLS_DIR) -> dict[str, SkillMeta]:
    registry: dict[str, SkillMeta] = {}

    if not skills_dir.exists():
        return registry

    for skill_file in sorted(skills_dir.glob("*/SKILL.md")):
        try:
            meta, _ = parse_skill_file(skill_file)
        except Exception as exc:
            print(f"[skill:skip] {skill_file}: {exc}")
            continue

        if meta.name in registry:
            print(f"[skill:skip] duplicate skill name: {meta.name}")
            continue

        registry[meta.name] = meta

    return registry


SKILL_REGISTRY = discover_skills()

def render_skill_catalog() -> str:
    if not SKILL_REGISTRY:
        return "No skills are available."

    lines = ["Available skills:"]
    for skill in SKILL_REGISTRY.values():
        lines.append(f"- {skill.name}: {skill.description}")

    return "\n".join(lines)

SYSTEM_PROMPT = f"""
你是一个编程助手，工作在当前目录：{WORKDIR}。
你可以使用工具读取文件、修改文件、执行必要命令、维护 Todo，并在需要时加载 Skill。

{render_skill_catalog()}

Skill 使用规则：
1. 如果用户任务明显匹配某个 Skill，先调用 load_skill 加载该 Skill 的完整说明。
2. 只加载当前任务需要的 Skill，不要一次性加载所有 Skill。
3. 加载 Skill 后，优先遵循 Skill 中的流程、检查清单和输出格式。
4. 如果没有匹配 Skill，就按普通 Agent 流程完成任务。
"""

LOAD_SKILL_TOOL = {
    "type": "function",
    "function": {
        "name": "load_skill",
        "description": (
            "Load the full instructions for a named skill. "
            "Use this before performing a task that matches an available skill."
        ),
        "parameters": {
            "type": "object",
            "properties": {
                "skill_name": {
                    "type": "string",
                    "description": "The name of the skill to load.",
                }
            },
            "required": ["skill_name"],
        },
    },
}

def run_load_skill(skill_name: str) -> str:
    name = skill_name.strip()
    meta = SKILL_REGISTRY.get(name)

    if meta is None:
        available = ", ".join(sorted(SKILL_REGISTRY)) or "none"
        return f"Error: unknown skill {name}. Available skills: {available}"

    loaded_meta, body = parse_skill_file(meta.path)
    if loaded_meta.name != meta.name:
        return f"Error: skill metadata changed while loading {name}"

    result = f"""
# Skill: {meta.name}

Description: {meta.description}

{body}
""".strip()

    return result[:20000]

TOOLS = [
    BASH_TOOL,
    LIST_DIR_TOOL,
    READ_FILE_TOOL,
    WRITE_FILE_TOOL,
    EDIT_FILE_TOOL,
    TODO_WRITE_TOOL,
    SUBAGENT_TOOL,
    LOAD_SKILL_TOOL,
]

TOOL_HANDLERS: dict[str, Callable[..., str]] = {
    "bash": bash,
    "list_dir": list_dir,
    "read_file": read_file,
    "write_file": write_file,
    "edit_file": edit_file,
    "run_todo_write": run_todo_write,
    "run_subagent": run_subagent,
    "load_skill": run_load_skill,
}

def check_permission(tool_name: str, arguments: dict[str, Any]) -> PermissionResult:
    if tool_name == "load_skill":
        return PermissionResult(
            "allow",
            "load_skill reads a registered skill file only",
        )

    # 其他规则沿用前几篇